Skip to content

Added sample heater display mode check in custom_pid function. #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianJKoopman merged 2 commits into from
Aug 26, 2024
Merged

Added sample heater display mode check in custom_pid function. #729

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a7134c
Added sample heater display mode check in custom_pid function.
mjrand Dec 28, 2023
dc8ba82
Merge branch 'main' into fix_custom_PID_display_mode_bug
BrianJKoopman Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions socs/agents/lakeshore372/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,12 @@ def custom_pid(self, session, params):
session.add_message('Changing control to Open Loop mode for sample PID.')
self.module.sample_heater.set_mode("Open Loop")

# Check we're in the correct display mode for servo.
# The custom PID expects that the sample heater is in 'current' mode
if self.module.sample_heater.display != "current":
session.add_message("Changing display mode to \'current\' for sample PID.")
self.module.sample_heater.set_heater_display("current")

if heater == 'still':
# Check we're in correct control mode for servo.
if self.module.still_heater.mode != 'Open Loop':
Expand Down