Pysmurf op data quality checks #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
msilvafe
approved these changes
May 23, 2024
Contributor
msilvafe
left a comment
msilvafe
left a comment
There was a problem hiding this comment.
This looks good, can you add one for take_noise method as well?
| block_data.update(QuantileData(**qd).to_block_data()) | ||
| data = { | ||
| 'timestamp': time.time(), | ||
| 'block_name': 'bias_steps_results', |
Contributor
There was a problem hiding this comment.
should be bias_wave_results
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
I'd like to test on satp1 or satp3 before merging.
Let me know when it's tested and I'll take a look.
Contributor
Author
|
This has now been tested on satp1, and quantiles are viewable in grafana: We need to figure out a good way to display these and set alarms on them, but I think this is ready for review @BrianJKoopman. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds quantiles for stats into session data for iv and bias step ops, and publishes them, so we can have some data quality metrics in grafana.
Description
Adds quantiles from Rn to IV op, and Rtes, Rfrac, and Si for bias steps / bias waves ops.
Motivation and Context
We would like to be able to tell immediately from grafana if there is an issue with detector data quality.
How Has This Been Tested?
Not yet tested. I'd like to test on satp1 or satp3 before merging.
Types of changes
Checklist: