error handling for flowmeter agent #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
One small comment, otherwise looks good!
BrianJKoopman
approved these changes
Mar 22, 2024
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks good, thanks for the update!
Contributor
Author
|
also, for completeness: just got the alarm that this flowmeter agent crashed once again at the site. the dev version running in the background did catch it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handling the following error for the flowmeter; noticed that pump skid 1 required frequent restarts due to this:
Motivation and Context
Need to implement connection error handling in agent
How Has This Been Tested?
Hasn't been tested at the site---currently have pump skid 1 agent with error handling running on daq-dev in case a connection error comes up soon. At the time of submitting this PR, no connection error has yet occurred.
Types of changes
Checklist: