Skip to content

Conversation

@BrianJKoopman
Copy link
Member

Description

This PR adds support for binding to a random available port when using the 'tcp' relay in the DeviceEmulator. This is now the default behavior. Tests that use this will need to grab the bound port via emulator.port to connect to.

Motivation and Context

This should fix the issue with flaky moxa tests seen in #633.

How Has This Been Tested?

Tested locally with the modifications to the tests here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@jlashner jlashner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks brian!

@BrianJKoopman
Copy link
Member Author

This doesn't actually solve the problem in #633, so I might hold off on merging.

@BrianJKoopman
Copy link
Member Author

Some very similar changes were made in #802, enabling random port selection, while maintaining the existing defaults. Closing, with remaining changes submitted in #934.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants