Supervisor updates #634
Merged
Supervisor updates #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks good to me, one docstring update to make, and a question about one of the time.sleep calls.
jlashner
force-pushed
the
supervisor-updates
branch
from
73292ac to
92f419e
Compare
for more information, see https://pre-commit.ci
BrianJKoopman
approved these changes
Feb 27, 2024
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Thanks for the updates!
hnakata-JP
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Updates from supervisor testing on satp3 * docstring for CheckInitialState * remove print statement * brian's comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
BrianJKoopman
pushed a commit
that referenced
this pull request
May 8, 2024
* Updates from supervisor testing on satp3 * docstring for CheckInitialState * remove print statement * brian's comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to HWP control logic from testing on SATP3 hardware with kyohei.
Description
A few changes to supervisor control logic including:
How Has This Been Tested?
Tested on SATp3 hardware
Types of changes
Checklist: