Restart UPS Agent every 60 minutes #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Member
|
Couple things:
|
mhasself
reviewed
Dec 10, 2023
BrianJKoopman
approved these changes
Dec 11, 2023
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Thanks for the updates!
hnakata-JP
pushed a commit
that referenced
this pull request
Apr 12, 2024
* exit ups agent after 60 min This is a temporary workaround to a memory leak in this agent. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * no crash in test mode * address comments * fix log * update docs * fix condition --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Break the acq process loop and exit the agent after 60 minutes. Must add
restart: unless-stoppedto docker-compose file to automatically restart the docker container everytime this occurs.Motivation and Context
Temporary fix for UPS agent which is the biggest contributor to high memory usage among site agents. This releases that memory by exiting the agent completely, which is what we've been doing manually. A fix to pysnmp, by switching to using asyncio, will come later.
How Has This Been Tested?
Tested in lab
Types of changes
Checklist: