ACU: permit scans on LAT even when Sun Avoidance is not to be enabled #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianJKoopman
approved these changes
Dec 8, 2023
hnakata-JP
pushed a commit
that referenced
this pull request
Apr 12, 2024
…#586) * ACU: full sun policy for LAT, though avoidance remains disabled * ACU: better behavior if Sun avoidance isn't configured * ACU: add proper return when monitor_sun exits on request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds basic Sun-safety "policy" for the LAT, even though avoidance won't be enabled for now. Without this the monitor_sun process just crashes.
Also makes sure that
_check_scan_sunsafeshort-circuits to True when avoidance is disabled (and to False if the map is not valid). This means that a sun-safety policy is not needed, if avoidance is disabled. The monitor_sun process will not be runnable, but that's ok.Motivation and Context
LAT could not scan; this was a bug.
How Has This Been Tested?
Tested on LAT in a few different configs. This should not affect how SATPs run.
Types of changes
Checklist: