Suprsync shouldn't try to copy ignored files #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
The file handling test is failing, please check the behavior is working properly there.
BrianJKoopman
approved these changes
Dec 6, 2023
hnakata-JP
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Suprsync don't try to copy ignored files * bugfix * Ignore flake8 warning in filter --------- Co-authored-by: Brian Koopman <brian.koopman@yale.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes suprsync get_copyable_files so that doesn't include ignored files.
Description
Changes suprsync get_copyable_files so that doesn't include ignored files.
Motivation and Context
We don't want to attempt to copy bad files.
How Has This Been Tested?
Not tested yet
Types of changes
Checklist: