Skip to content

ACU: feeds for Sun info and UDP stream quality #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrianJKoopman merged 3 commits into from
Dec 4, 2023
Merged

ACU: feeds for Sun info and UDP stream quality #570

BrianJKoopman merged 3 commits into from
Dec 4, 2023

Conversation

@mhasself
Copy link
Member

@mhasself mhasself commented Nov 13, 2023

Description

  1. Publish the sun position (az, el), its distance, the current sun-safety time, and flags indicating if an escape is active.
  2. Publish whether the UDP stream is active, and the time-of-flight time difference on the samples.

Motivation and Context

These are both intended to facilitate alerts / heads up display in grafana.

How Has This Been Tested?

Verified on SATP2, daq-dev.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

BrianJKoopman
BrianJKoopman approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BrianJKoopman BrianJKoopman merged commit b851382 into main Dec 4, 2023
@BrianJKoopman BrianJKoopman deleted the mhasself/acu-feeds branch December 4, 2023 16:06
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
@mhasself @d-hoshino2626
ACU: Add feeds for Sun info and UDP stream quality (#570)
1908119 
* ACU sun: add a feed with sun info (position, state of escape)

* ACU: feed for UDP data health variable

* ACU: remove useless "from_reactor" args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrianJKoopman BrianJKoopman BrianJKoopman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhasself @BrianJKoopman