Skip to content

Conversation

@jlashner
Copy link
Contributor

@jlashner jlashner commented Nov 7, 2023

Adds routine in suprsync main function to regularly update timecode-directories for files that have not been added with the add_file interface.

Description

There is currently an issue with the suprsync finalization, where timecode directories are not being added for files added by the pysmurf-monitor, since it does not use the add_file function in suprsync. This fixes that issue, by having the suprsync agents regularly (like every 6 hrs) add the TimecodeDir if it does not exist for any file added in the last week.

Motivation and Context

Required to fix finalization and smurf bookbinding.

Resolves #562

How Has This Been Tested?

Tested with smurf-sync on smurf-srv20

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. One docstring comment. Also, can you confirm this resolves #562? (And link this PR to that issue by putting "Resolves #562" under the "Motivation and Context" section.)

@jlashner jlashner linked an issue Nov 7, 2023 that may be closed by this pull request
@jlashner
Copy link
Contributor Author

jlashner commented Nov 7, 2023

Yep, confirmed

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BrianJKoopman BrianJKoopman merged commit bc52694 into main Nov 7, 2023
@BrianJKoopman BrianJKoopman deleted the suprsync-update-tcdirs branch November 7, 2023 23:38
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
* Make suprsync regularly add timecode dirs for recently added files

* add log statement

* bugfix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add docstring for min_ctime

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SupRsync adding finalize files every other day

2 participants