Adds general task to set TES biases #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We could really use these functions running in the field. What's needed to get it going there? |
BrianJKoopman
requested changes
Oct 30, 2023
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks good, mostly docstring related requests.
Contributor
Author
|
sorry that took so long, but addressed @BrianJKoopman's feedback |
BrianJKoopman
approved these changes
Nov 7, 2023
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Thanks for the updates!
hnakata-JP
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Adds general task to set TES biases * Adds zero_biases task * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix typo * address brian's comments --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Brian Koopman <brian.koopman@yale.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a general task to set tes biases to specified values, and a separate task to zero biases. Resolves #544.
Description
Adds a needed function to the pysmurf-controller
set_biasesthat lets you generally set tes biases. Also addszero_biasestask which can makes it easier to zero all biases from OCS web.Motivation and Context
We need more control over TES biases from pysmurf-controller.
How Has This Been Tested?
Not tested yet.
Types of changes
Checklist: