Addressed (most of) Issue #531 #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhasself
reviewed
Oct 6, 2023
mhasself
requested changes
Oct 10, 2023
Member
mhasself
left a comment
mhasself
left a comment
There was a problem hiding this comment.
Thanks, UV fix looks good. Please use function for F_to_C. It is then self-documenting and less prone to little typos.
mhasself
approved these changes
Oct 11, 2023
mhasself
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Address Issue #531 * Correct UVI overflow calculation * Write fahrenheit to celsius conversion function to use when collecting temperature data * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
6 tasks
hnakata-JP
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Address Issue #531 * Correct UVI overflow calculation * Write fahrenheit to celsius conversion function to use when collecting temperature data * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Issue #531
How Has This Been Tested?
I ran python in terminal and created functions that take dummy input values and output the changed value.
These functions reflected the changes I made in the agent.
Types of changes
Checklist:
There are comments in code that should be changed (instances of 'fahrenheit' to 'celsius')