Adds default to input_configfile param #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianJKoopman
requested changes
Sep 29, 2023
| @@ -1305,7 +1305,7 @@ def get_still_output(self, session, params=None): | |||
|
|
|||
| return True, "Current still output is {}".format(still_output) | |||
|
|
|||
| @ocs_agent.param('configfile', type=str) | |||
| @ocs_agent.param('configfile', type=str, default=None) | |||
There was a problem hiding this comment.
Also update the method signature override in the docstring to be: input_configfile(configfile=None)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default to input_configfile so it can be run from ocs-web
Description
Adds default to input_configfile so it can be run from ocs-web
Motivation and Context
so it can be run from ocs-web w/out providing a path
How Has This Been Tested?
not been tested yet
Types of changes
Checklist: