Publish BF logs only if data extracted from them #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianJKoopman
force-pushed
the
koopman/bluefors-status-dropouts
branch
from
28195d5 to
9060788
Compare
BrianJKoopman
force-pushed
the
koopman/bluefors-status-dropouts
branch
from
9060788 to
5d2b516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the BF agent to only publish to the feed if any actual data has been pulled from the logs.
Motivation and Context
This should prevent the agent from trying to publish blank lines from the logs, which cause the crash detailed in #515.
Fixes #515.
How Has This Been Tested?
Tested by running the agent locally and writing example logs based on the example that causes the failure in #515. Agent remained online during testing.
Types of changes
Checklist: