LATRt Updates #419
Open
LATRt Updates #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8ed55f6.
for more information, see https://pre-commit.ci
BrianJKoopman
requested changes
Mar 1, 2023
Comment on lines
+169
to
+170
| """Tell the controller to hold stages enabled | ||
| """ |
There was a problem hiding this comment.
The docstring here needs the method signature override, like the first line of the other docstrings in this agent. It also should identify the method as a Task or Process. For this it would be:
"""set_enabled()
**Task** - Tell the controller to hold stages enabled.
Same comment applies to set_disabled.
Comment on lines
+180
to
+191
| @ocs_agent.param('_') | ||
| def set_disabled(self, session, params=None): | ||
| """Tell the controller to hold stages enabled | ||
| """ | ||
| with self.lock.acquire_timeout(timeout=3, job='set_disabled') as acquired: | ||
| if not acquired: | ||
| self.log.warn( | ||
| f"Could not set position because lock held by {self.lock.job}") | ||
| return False, "Could not acquire lock" | ||
|
|
||
| self.xy_stage.disable() | ||
| return True, "Disabled" |
There was a problem hiding this comment.
Docstring comment aside, while this command structure is similar to structures we have in other agents, it would probably be better to combine this two tasks into one that takes a single boolean argument that enables/disables the hold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some weird merging issues that must have gotten through checks when this agent was last moved around. But those are now fixed.
Also fixing some bugs that showed up as we were restarting testing this year.