HWP Gripper agent unexpected keyword argument 'mcu_ip'

[davidvng]

I'm getting "unexpected keyword argument" error when initializing the HWPGripperAgent. I'm guessing it might be from this line:

socs/socs/agents/hwp_gripper/agent.py

Line 28 in 5960617

def __init__(self, agent, args):

Should likely be *args instead?

[BrianJKoopman]

Should likely be *args instead?

A reasonable assumption, but no, args is the Namespace object that comes from the argparse parser. It's passed in directly in this case, not argument by argument. Not uncommon in our agents, see for instance the pysmurf-controller.

Did this commit end up fixing the issue?

[davidvng]

No, that didn't fix the issue, here's the full error:

File "/usr/local/lib/python3.8/dist-packages/socs/agents/hwp_gripper/agent.py", line 679, in main
gripper_agent = HWPGripperAgent(agent, mcu_ip=args.mcu_ip,
TypeError: __init__() got an unexpected keyword argument 'mcu_ip'

[BrianJKoopman]

Ah, it looks like there's a mix of explicit argument definition and using the Namespace object. The HWPGripperAgent instantiation on line 679 is passing all arguments explicitly, while the the way the class is written expects line 679 to just be:

    gripper_agent = HWPGripperAgent(agent, args)