Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hook arguments, plugins, add hooks #25

Merged
merged 31 commits into from
Jan 26, 2024
Merged

Update hook arguments, plugins, add hooks #25

merged 31 commits into from
Jan 26, 2024

Conversation

TaiSakuma
Copy link
Member

So that plugins can be used instead of Nextline's methods subscribe_*

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (082489e) 86.39% compared to head (ce4fefd) 85.94%.

Files Patch % Lines
nextline/plugin/plugins/session/session.py 85.71% 6 Missing and 5 partials ⚠️
nextline/spawned/plugin/plugins/local_.py 31.25% 11 Missing ⚠️
nextline/utils/run.py 70.37% 6 Missing and 2 partials ⚠️
nextline/spawned/plugin/plugins/repeat.py 54.54% 5 Missing ⚠️
nextline/spawned/types.py 70.58% 5 Missing ⚠️
nextline/plugin/plugins/session/monitor.py 85.71% 3 Missing and 1 partial ⚠️
nextline/spawned/path.py 80.00% 1 Missing and 2 partials ⚠️
nextline/spawned/plugin/spec.py 66.66% 2 Missing ⚠️
nextline/plugin/spec.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   86.39%   85.94%   -0.46%     
==========================================
  Files         113      113              
  Lines        4286     4304      +18     
  Branches      706      710       +4     
==========================================
- Hits         3703     3699       -4     
- Misses        526      543      +17     
- Partials       57       62       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TaiSakuma TaiSakuma merged commit e9e9c1f into main Jan 26, 2024
8 of 12 checks passed
@TaiSakuma TaiSakuma deleted the dev branch January 26, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant