Add tests for theory components Bandpass and Foreground #119
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
=======================================
Coverage 73.12% 73.12%
=======================================
Files 30 30
Lines 1935 1935
=======================================
Hits 1415 1415
Misses 520 520 |
itrharrison
changed the title
|
Since there is a potential conflict between this branch and the branch opened by @sgiardie to document MFLike, I suggest that we postpone adding documentation to BandPass and Foreground until MFLike is done. Things changed with this PR and addressing #115:
|
There was a problem hiding this comment.
This looks good, at the moment the tests for the foregrounds form some re-implementation of various functions in the Theory class here in the tests and checking they give the same answer. This checks a lot of things well, as it seems unlikely mistakes would have occured in both implementations.
It would also be nice to have some physical sanity checks along the lines of ratios of spectra > or < 1 at different frequencies (for example), just to check that the spectra being calculated have the expected physical properties.
itrharrison
dismissed
their stale review
On reflection I think my suggested test is one for fgspectra not us here.
* added test files for bandpass theory class * updated reqs * checked style * added tests for foreground theory component --------- Co-authored-by: Martina Gerbino <bradamante@martina.local> Co-authored-by: Ian Harrison <itrharrison@gmail.com>
No description provided.