Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved cosmopower default parameters to yaml files. #106

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

HTJense
Copy link
Member

@HTJense HTJense commented Feb 28, 2023

As planned for the v0.1 milestone, I moved the cosmopower default parameters to yaml files instead of the python classes.

@HTJense HTJense added this to the v0.1 milestone Feb 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #106 (475452e) into master (8663822) will decrease coverage by 0.27%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   61.72%   61.45%   -0.27%     
==========================================
  Files          30       30              
  Lines        1941     1930      -11     
==========================================
- Hits         1198     1186      -12     
- Misses        743      744       +1     
Impacted Files Coverage Δ
soliket/cosmopower.py 66.00% <ø> (-2.95%) ⬇️

Copy link
Collaborator

@itrharrison itrharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the default parameters, can we either give them a value or add a comment on the line with an example value? So it does not look so blank and mysterious to the user.

@itrharrison itrharrison added documentation Improvements or additions to documentation theory Related to cobaya Theories labels Feb 28, 2023
@itrharrison itrharrison merged commit 2b52cb2 into master Feb 28, 2023
@itrharrison itrharrison deleted the dev-cosmopower-yaml branch February 28, 2023 12:58
mgerbino pushed a commit that referenced this pull request Oct 4, 2023
* Moved cosmopower default settings to yaml.

* Removed tmp test files.

* Removed tmp test files.

* Added comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation theory Related to cobaya Theories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants