Skip to content

Commit

Permalink
addressing comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sgiardie committed Jun 6, 2023
1 parent 003d6d9 commit 83f673c
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 22 deletions.
10 changes: 7 additions & 3 deletions soliket/BandPass.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
data_folder: MFLike/v0.8

# Three options for passband construction (top_hat_band, external_bandpass,
# read_from_sacc). Fill the corresponding dictionary to select one of the
# options. The other dictionaries have to be left empty. Default is
# read_from_sacc.

# Parameters to build a top-hat band:
# - nsteps sets the number of frequencies used in the band integration
Expand Down Expand Up @@ -38,10 +42,10 @@ read_from_sacc: True
params:
bandint_shift_LAT_93:
value: 0
latex: \Delta_{\rm band}^{93}
latex: \Delta_{\rm LAT}^{93}
bandint_shift_LAT_145:
value: 0
latex: \Delta_{\rm band}^{145}
latex: \Delta_{\rm LAT}^{145}
bandint_shift_LAT_225:
value: 0
latex: \Delta_{\rm band}^{225}
latex: \Delta_{\rm LAT}^{225}
10 changes: 4 additions & 6 deletions soliket/bandpass.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def _cmb2bb(nu):
:param nu: frequency array
:return: the array :math:`\frac{\partial B_{\nu}}{\partial T}`
:return: the array :math:`\frac{\partial B_{\nu}}{\partial T}`. See note above.
"""
# NB: numerical factors not included
x = nu * h_Planck * 1e9 / k_Boltzmann / T_CMB
Expand Down Expand Up @@ -159,9 +159,9 @@ def initialize(self):
if (not self.read_from_sacc and not self.use_top_hat_band
and not self.bandint_external_bandpass):
raise LoggedError(
self.log, "fill the dictionaries for either reding" \
"the passband from sacc file (mflike default) or an"\
"external passband or building a top-hat one!"
self.log, "fill the dictionaries in the yaml file for" \
"either reading the passband from sacc file (mflike default)" \
"or an external passband or building a top-hat one!"
)


Expand All @@ -183,8 +183,6 @@ def must_provide(self, **requirements):
self.bands = requirements["bandint_freqs"]["bands"]
self.exp_ch = [k.replace("_s0", "") for k in self.bands.keys()
if "_s0" in k]
# self.eff_freqs = [np.array(self.bands[k]['nu'])
# for k in self.bands.keys()]

def calculate(self, state, want_derived=False, **params_values_dict):
r"""
Expand Down
4 changes: 3 additions & 1 deletion soliket/foreground.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ def _get_foreground_model(self,
if hasattr(eff_freqs, '__len__'):
bandint_freqs = np.asarray(eff_freqs)
else:
self.log.info("no frequency list provided to compute the passbands")
raise LoggedError(
self.log, "no frequency list provided to compute the passbands"
)


model = {}
Expand Down
24 changes: 12 additions & 12 deletions soliket/mflike/TheoryForge_MFLike.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,40 +21,40 @@ params:
# Systematics
cal_LAT_93:
value: 1
latex: \mathrm{Cal}^{93}
latex: \mathrm{Cal}_{\rm LAT}^{93}
cal_LAT_145:
value: 1
latex: \mathrm{Cal}^{145}
latex: \mathrm{Cal}_{\rm LAT}^{145}
cal_LAT_225:
value: 1
latex: \mathrm{Cal}^{225}
latex: \mathrm{Cal}_{\rm LAT}^{225}
calT_LAT_93:
value: 1
latex: \mathrm{Cal}_{\rm T}^{93}
latex: \mathrm{Cal}_{\rm LAT, T}^{93}
calE_LAT_93:
value: 1
latex: \mathrm{Cal}_{\rm E}^{93}
latex: \mathrm{Cal}_{\rm LAT, E}^{93}
calT_LAT_145:
value: 1
latex: \mathrm{Cal}_{\rm T}^{145}
latex: \mathrm{Cal}_{\rm LAT, T}^{145}
calE_LAT_145:
value: 1
latex: \mathrm{Cal}_{\rm E}^{145}
latex: \mathrm{Cal}_{\rm LAT, E}^{145}
calT_LAT_225:
value: 1
latex: \mathrm{Cal}_{\rm T}^{225}
latex: \mathrm{Cal}_{\rm LAT, T}^{225}
calE_LAT_225:
value: 1
latex: \mathrm{Cal}_{\rm E}^{225}
latex: \mathrm{Cal}_{\rm LAT, E}^{225}
calG_all:
value: 1
latex: \mathrm{Cal}_{\rm G}^{\rm All}
alpha_LAT_93:
value: 0 #deg
latex: \alpha^{93}
latex: \alpha_{\rm LAT}^{93}
alpha_LAT_145:
value: 0 #deg
latex: \alpha^{145}
latex: \alpha_{\rm LAT}^{145}
alpha_LAT_225:
value: 0 #deg
latex: \alpha^{225}
latex: \alpha_{\rm LAT}^{225}

0 comments on commit 83f673c

Please sign in to comment.