correct bandpass construction in the presence of shifts #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a mistake in the current construction of the transmission from the bandpasses, in the presence of bandpass shift.
In the current version we are doing:
while we should do:
so we should use the shifted frequency array
nub
both at the numerator and the denominator oftrans
This way, we assume that the cmb component would always have
trans
= 1 (since the cmb component can come out of the integral and the numerator and denominator can simplify)This is implicitly what we are already doing by summing the cmb theory spectra to the foreground spectra integrated in band:
cmbfg_dict[s, exp1, exp2] = Dls[s] + fg_dict[s, "all", exp1, exp2]
The current version works fine when
bandpass_shifts = 0
.