Support custom sized barcodes with transparent background #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsickle
approved these changes
Jan 23, 2023
Owner
simonsickle
left a comment
simonsickle
left a comment
There was a problem hiding this comment.
LGTM, just a couple small things before a merge
Comment on lines
-101
to
-102
| @Composable | ||
| fun Barcode( |
Owner
There was a problem hiding this comment.
Let's not remove this until v2 please
| val offset = y * width | ||
| for (x in 0 until width) { | ||
| pixels[offset + x] = if (get(x, y)) android.graphics.Color.BLACK else android.graphics.Color.WHITE | ||
| pixels[offset + x] = if (get(x, y)) android.graphics.Color.BLACK else android.graphics.Color.TRANSPARENT |
| val offset = y * width | ||
| for (x in 0 until width) { | ||
| pixels[offset + x] = if (get(x, y)) android.graphics.Color.BLACK else android.graphics.Color.WHITE | ||
| pixels[offset + x] = if (get(x, y)) android.graphics.Color.BLACK else android.graphics.Color.TRANSPARENT |
There was a problem hiding this comment.
It would also be nice to have the main color being passed from the barcode view and not be black all the time :)
|
Any plans to merge this? |
Owner
|
I've been working on V2 in the background which transitions over to more efficient drawing and uses the compose canvas (lets this work on compose desktop, for example) That said, I can merge this in the interim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13