feat: improve UX by don't reject empty tags

simonknittel · Jan 1, 2025 · 666933c · 666933c
1 parent 8e526fc
commit 666933c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/app/src/fleet/actions/createVariant.ts b/app/src/fleet/actions/createVariant.ts
@@ -15,8 +15,8 @@ const schema = z.object({
   status: z
     .enum([VariantStatus.FLIGHT_READY, VariantStatus.NOT_FLIGHT_READY])
     .optional(),
-  tagKeys: z.array(z.string().trim().min(1)).optional(),
-  tagValues: z.array(z.string().trim().min(1)).optional(),
+  tagKeys: z.array(z.string().trim()).optional(),
+  tagValues: z.array(z.string().trim()).optional(),
 });
 
 export const createVariant = async (formData: FormData) => {

diff --git a/app/src/fleet/actions/updateVariant.ts b/app/src/fleet/actions/updateVariant.ts
@@ -15,8 +15,8 @@ const schema = z.object({
   status: z
     .enum([VariantStatus.FLIGHT_READY, VariantStatus.NOT_FLIGHT_READY])
     .optional(),
-  tagKeys: z.array(z.string().trim().min(1)).optional(),
-  tagValues: z.array(z.string().trim().min(1)).optional(),
+  tagKeys: z.array(z.string().trim()).optional(),
+  tagValues: z.array(z.string().trim()).optional(),
 });
 
 export const updateVariant: ServerAction = async (formData) => {

diff --git a/app/src/fleet/components/CreateVariantModal.tsx b/app/src/fleet/components/CreateVariantModal.tsx
@@ -145,15 +145,13 @@ export const CreateVariantModal = ({
                 className="p-2 rounded bg-neutral-900 flex-1 min-w-0"
                 name="tagKeys[]"
                 placeholder="Key"
-                required
                 defaultValue={tag.key}
               />
               <input
                 type="text"
                 className="p-2 rounded bg-neutral-900 flex-1 min-w-0"
                 name="tagValues[]"
                 placeholder="Value"
-                required
                 defaultValue={tag.value}
               />
               <Button

diff --git a/app/src/fleet/components/UpdateVariantModal.tsx b/app/src/fleet/components/UpdateVariantModal.tsx
@@ -111,15 +111,13 @@ export const UpdateVariantModal = ({ onRequestClose, variant }: Props) => {
                 className="p-2 rounded bg-neutral-900 flex-1 min-w-0"
                 name="tagKeys[]"
                 placeholder="Key"
-                required
                 defaultValue={tag.key}
               />
               <input
                 type="text"
                 className="p-2 rounded bg-neutral-900 flex-1 min-w-0"
                 name="tagValues[]"
                 placeholder="Value"
-                required
                 defaultValue={tag.value}
               />
               <Button