-
Notifications
You must be signed in to change notification settings - Fork 0
Add: 웹 뷰 Refactoring #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simoniful
wants to merge
22
commits into
master
Choose a base branch
from
MVVM+C
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
코디네이터 구성 WebView MVVM+C 전환 Util 정의
In/Out 정리 코디네이터 세팅 및 전달인자 전달 table 구성 관련 이슈
bind 연결 및 기존 함수 리팩토링
…into MVVM+C Merge old repo;
List View Controller 정리
delegate 연결
Large title 관련 애니메이션 수정
ViewModel 구체화 코디네이터 연결 ViewController 정리
ViewModel 구성 및 rx 연결 코디네이터 연결 인터렉션 관련 삭제, 추가 코드 구성 제스쳐 관련 키보드 컨트롤 토스트 관련 구성
News 확장 및 내부 emit 로직 분리
스크랩 관련 테스트 작성 Coordinator 로직 리팩토링 Minor 부분 리팩토링 네트워크 에러 토스트 구성
ViewModel 전체 기반 테스트 케이스 구성 News 모델 Equalable 프로토콜 준수 Mock Repo 수정
Input 관련 데이터 스트림 구성 스트림에 맞는 내부 데이터 변화 관찰 비교 Mock 구성
Mock 구성 기본 동작 테스트 케이스 작성
Mock 구성 기본 동작 테스트 케이스 작성
1차 수정
Test Coverage 이미지 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코디네이터 구성
WebView MVVM+C 전환
Util 정의