Fix travis build issue #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi there, would be mind squashing all the commits in to one? |
Contributor
Author
Please go ahead.
I agree, they should update their doc as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that recent travis builds failed for a reason that has nothing to do with the code.
After some searching, I've found that cmake should be run in googletest's home directory, not googletest/googletest.
So this PR revise
GTEST_PATHand update the include directory intests/Makefileaccordingly.You can see that these changes make travis build successfully: https://travis-ci.org/github/keineahnung2345/mve/jobs/757523169.