-
Notifications
You must be signed in to change notification settings - Fork 422
Support for importing Colmap SfM models #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Once #510 is merged, I'll update this PR accordingly (i.e. rebasing this on the master branch) |
|
Side note, I've used the addon mentioned in #512 to import a Colmap reconstruction and the corresponding MVE workspace using the functionality provided by this PR. The camera poses and points aligned perfectly. |
|
Rebased and Squashed the commits |
|
Another side note: I figured out that colmap exports nvm files with feature observation positions within |
I believe in the bundle MVE expects [0,width]x[0,height]. In SfM code it's a little different and centered around 0 to apply radial distortion. |
|
Would you mind squashing and force commiting the PR? It'll get a little easier to review. |
|
No problem. I'm afraid, I'm not an github review expert either :o |
|
I'm merging this for now. I'm still not convinced with the |
|
Thanks for your contribution! |
|
Thx for merging! |
|
I've done some experiments and could verify that Here a result with And here a result with Btw: |
|
Thank you for confirming it works. This is a nice reconstruction. What was the software process for reconstructing this? How was the imagery taken? |
|
Also, have you tried using UMVE for mesh inspection? It doesn't have a ton of features, but it's faster than Meshlab. |
The sfm part has been performed with this colmap fork. Other pre- and post processing steps have been performed with some custom code. The imagery is part of https://spacenetchallenge.github.io/datasets/mvs_summary.html
Oh, I wasnt aware of that. Thanks for pointing out. |



This PR allows to import Colmap's SfM model formats (
.binas well as.txtfiles).Let us assume the following folder structure:
The importer looks on the same level than the
<sparse model>for the<image folder>with the corresponding images.Also, the importer searches first for the
.txtfiles in the<sparse model>folder.In order to validate the imported results, I performed a reconstruction with Colmap and exported the results as
.NVMfile as well as Colmap's standard model folders (.txt and .bin). Then, I compared the values in theBundle::Ptrreturned byload_nvm_bundleandload_colmap_bundle. I did not add the testing code, since I did not find a suitable place in the MVE library.If you have any questions or comments, please let me know.