Skip to content

Upgrade ava and argon2 versions #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

thetutlage
Copy link

Since, Ava has received a major update, have to tweak the tests a little to get them passing.

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@900c5ae). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head d5dcd92 differs from pull request most recent head 4489a4a. Consider uploading reports for the commit 4489a4a to get more accurate results

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage          ?   98.83%           
=========================================
  Files             ?        1           
  Lines             ?       86           
  Branches          ?        0           
=========================================
  Hits              ?       85           
  Misses            ?        1           
  Partials          ?        0           
Impacted Files Coverage Δ
index.js 98.83% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thetutlage
Copy link
Author

There seems to an issue with eslint-plugin-import that is making it fail on windows. import-js/eslint-plugin-import#1643

Apart from that the PR must be good to go. If required, I can squash commits to a single commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant