Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libfaketime/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def __init__(self, datetime_spec, only_main_thread=True, tz_offset=None):
if datetime_spec.tzinfo:
if tz_offset is not None:
raise Exception('Cannot set tz_offset when datetime already has timezone')
self.timezone_str = datetime_spec.tzinfo.zone
self.timezone_str = datetime_spec.tzinfo.tzname(datetime_spec)

def _should_fake(self):
return not self.only_main_thread or threading.current_thread().name == 'MainThread'
Expand Down
11 changes: 11 additions & 0 deletions test/test_tz.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import datetime
import dateutil.tz
import os

import pytest
Expand Down Expand Up @@ -53,3 +54,13 @@ def test_generated_tz_is_valid(offset):
with fake_time(now, tz_offset=offset):
fake_tz = os.environ['TZ']
timezone(fake_tz) # should not raise pytzdata.exceptions.TimezoneNotFound


def test_dateutil_tz_is_valid():
test_dt = datetime.datetime(2017, 1, 2, 15, 2)
dateutil_tzinfo = dateutil.tz.gettz('UTC')
dt_dateutil_tzinfo = test_dt.replace(tzinfo=dateutil_tzinfo)

# Should be compatible with a dateutil tzinfo object, not just pytz
with fake_time(dt_dateutil_tzinfo):
assert datetime.datetime.now(tz=dateutil_tzinfo) == dt_dateutil_tzinfo