- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
Remove default exports in react components that display content #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
--- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/simnova/ownercommunity?shareId=XXXX-XXXX-XXXX-XXXX).
| Reviewer's Guide by SourceryThis pull request removes default exports from React components that display content, opting for named exports instead. The changes are primarily focused on modifying export statements in various component files. Class diagram for updated React componentsclassDiagram
    class App {
        +App()
    }
    class UserInfoContainer {
        +UserInfoContainer()
    }
    class RolesDetailContainer {
        +RolesDetailContainer(RolesDetailContainerProps props)
    }
    class ServiceTicketsDetailContainer {
        +ServiceTicketsDetailContainer(ServiceTicketsDetailContainerProps props)
    }
File-Level Changes
 Tips and commandsInteracting with Sourcery
 Customizing Your ExperienceAccess your dashboard to: 
 Getting Help
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gidich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Review instructions: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| import MaintenanceMessageProvider from './components/shared/maintenance-message'; | ||
| import { useFeatureFlags } from './components/shared/feature-flag-react-lite'; | ||
|  | ||
| function App() { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (review_instructions): Missing props interface for App component
Please define an interface named 'AppProps' for the component's props, even if it's currently empty. Refer to '002-ui-tsx-files.md' for more information on prop interfaces.
Review instructions:
Path patterns: ui-*/**/*.tsx
Instructions:
- The exported react component name should match the container name (the file name should be kabob-cased, and the component name should be PascalCased) unless the file name is index.tsx, then the component name should match the parent folder name.
- The component should be a functional component.
- An interface or type should be defined for the component's props, named <ComponentName>Props.
- the props should refer to data only by the fragment name or graphql input type name
 
- Any use of the AntDesign Table should leverage TableColumnsType and must specify the type of the data (usually the fragment type)
- Any use of the AntDesign useForm hook must specify the type of the form data (usually the GraphQL input type)
- If any of the above rules are broken, direct the developer to refer to the document file named 002-ui-tsx-files.md
- An interface should be defined for the component's props, named <ComponentName>Props.
- the props should refer to data only by the fragment name or graphql input type name
 
- Any use of the AntDesign Table should leverage TableColumnsType and must specify the type of the data (usually the fragment type)
- Any use of the AntDesign useForm hook must specify the type of the form data (usually the GraphQL input type)
- If any of the above rules are broken, direct the developer to refer to the document file named 002-ui-tsx-files.md
For more details, open the Copilot Workspace session.
Summary by Sourcery
Remove default exports from React components and replace them with named exports to enhance code consistency and maintainability.
Enhancements: