Improve exception stack printing (JuliaLang#36606)

The expanded stacktrace printing introduced in JuliaLang#36134 and the fact that we no longer print errors in red (JuliaLang#36015) makes it harder to distinguish distinct exceptions in the stack. Add a newline for this, and print the "caused by" in error_color(). Also remove exception numbering which was arguably not very helpful.
simeonschaub · Aug 11, 2020 · dcd1dbc · dcd1dbc
1 parent 40355e1
commit dcd1dbc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/base/errorshow.jl b/base/errorshow.jl
@@ -872,7 +872,7 @@ function show_exception_stack(io::IO, stack::Vector)
     nexc = length(stack)
     for i = nexc:-1:1
         if nexc != i
-            printstyled(io, "caused by [exception ", i, "]\n", color=:light_black)
+            printstyled(io, "\ncaused by:\n", color=error_color())
         end
         exc, bt = stack[i]
         showerror(io, exc, bt, backtrace = bt!==nothing)

diff --git a/test/client.jl b/test/client.jl
@@ -11,7 +11,8 @@ end
 nested_error_pattern = r"""
     ERROR: DivideError: integer division error
     Stacktrace:.*
-    caused by \[exception 1\]
+
+    caused by:
     UndefVarError: __not_a_binding__ not defined
     Stacktrace:.*
     """s