fix: remove another instance where we copy#14
Merged
FranciscoThiesen merged 1 commit intofast_prototypefrom May 27, 2024
Merged
fix: remove another instance where we copy#14FranciscoThiesen merged 1 commit intofast_prototypefrom
FranciscoThiesen merged 1 commit intofast_prototypefrom
Conversation
Member
|
Nice catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
struct_to_tupleeffectively creates a temporary copy of the struct, which means copying the strings in particular. Using references instead is better.Numbers:
This is still not what we would like. What we should try to do is to avoid the construction of a tuple entirely at runtime. I'll open an issue.