x86 avx: fix native implementation of simde_mm256_permute2f128_si256#1338
Merged
mr-c merged 3 commits intosimd-everywhere:masterfrom Sep 23, 2025
Merged
x86 avx: fix native implementation of simde_mm256_permute2f128_si256#1338mr-c merged 3 commits intosimd-everywhere:masterfrom
simde_mm256_permute2f128_si256#1338mr-c merged 3 commits intosimd-everywhere:masterfrom
Conversation
Collaborator
Contributor
Author
|
Thanks again @mr-c. Unfortunately I don't know where to begin locating the error. It seems to originate in a file called avx.cpp that is generated ? And only for MVSC (which I don't have access to). Any pointers how to attack this would be appreciated. |
mr-c
changed the title
simde_mm256_permute2f128_si256
Collaborator
@ethomag I fixed it for you already; just click the "merge" button at ethomag#1 |
x86 avx: fix test for MSVC where CONSTIFY doesn't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mr-c and thanks for a great library!
This is to correct the typo that caused: #1337 "simde_mm256_permute2f128_si256 does not map to the native asm instruction when compiling for AVX2"
I am happy to take a shot at the tests at a later stage.