Add sound null safety#76
Merged
simc merged 34 commits intosimc:masterfrom Nov 24, 2020
timsneath:master
Merged
Conversation
Migrate package to support sound null safety
Owner
|
Perfect, thanks 😊 |
Contributor
Author
|
You're a hero! Thanks. I use this package myself for my Dad Jokes app so it was fun to use as a test case for our migration tools. By the way, you can publish this to pub.dec side by side with the existing version. This will show up as a prerelease for those who are running in sound null safety mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request provides support for sound null safety in the package, per https://dart.dev/null-safety/migration-guide. This code is compatible with null safe Flutter apps. It doesn't attempt to remove nullable members, but for non-nullable members, it does away with unnecessary null checking.
It is versioned as
v3.0.0-nullsafety.0per the guidance in the above document.There are a couple of warnings in the demo/ folder for dependencies that haven't been migrated; hopefully those will get migrated before null-safety is stable. At that time, the version should be bumped up to include those null-safe versions.
One note: I see that bottom_navy_bar no longer supports more than four buttons. As a result, I've left that at the lower version rather than updating it as part of this migration.