colormap: allow users to provide percentile values for 'PERCENTILE' mode #4379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payno
changed the title
payno
changed the title
payno
force-pushed
the
4123-add_new_ercentiles_v2
branch
3 times, most recently
from
42bd259 to
a41219e
Compare
1 task
payno
force-pushed
the
4123-add_new_ercentiles_v2
branch
2 times, most recently
from
1aa29cf to
ff9a24f
Compare
t20100
reviewed
Sep 12, 2025
Member
t20100
left a comment
t20100
left a comment
There was a problem hiding this comment.
There's some unrelated changes embedded in this PR to clean up.
IMO SliderWithSpinBox is not worth making public.
I would consider a int slider rather than floats
Looks good to have API with range and a slider + spin box looks good to me!
payno
force-pushed
the
4123-add_new_ercentiles_v2
branch
2 times, most recently
from
88d6f85 to
f0df5ce
Compare
payno
changed the title
t20100
reviewed
Sep 16, 2025
Member
t20100
left a comment
t20100
left a comment
There was a problem hiding this comment.
ColormapDialog is already a lengthy piece of code. IMO it's best to off-load code when we can, so I propose to turn the SliderWithSpinBox into a specific PercentileWidget containing all the code regarding widget init/sync and 1-value <-> 2-tuple conversion
…ly 1-99 # Conflicts: # src/silx/utils/cache.py
* remove 'saturation' label * label layout: align to top
…usedPercentile'. Which might be a bit more 'understandable' (and the link to the percentile)
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
…etAutoscalePercentiles
…ntileRange' to 'fromPercentilesToSaturation' and 'fromLateralPercentileRangeToCentralPercentile' to 'fromSaturationToPercentiles'
…en, overwrite percnetile to make sure we have 1, 99
… one added by the PR, not modifying ohers to avoid any API break)
payno
force-pushed
the
4123-add_new_ercentiles_v2
branch
from
6d2f414 to
a6c6e3d
Compare
* replace emission of 'valueChanged' by 'percentilesChanged' as this is the one we want from the Colormap * move 'setRange' to protected because can be confusing with 'setPercentilesRange' * rename 'value' by 'getSaturationValue' because this is more clearer and avoid confusion. * add 'setPercentilesRange' and 'getPercentilesRange' API * fix 'setSaturationValue'
payno
commented
Sep 18, 2025
Member
Author
payno
left a comment
payno
left a comment
There was a problem hiding this comment.
I reworked the ColormapPercentilesWidget. Indeed it seems a bit more concise 🤞
…rder to make sure it receives int only
payno
force-pushed
the
4123-add_new_ercentiles_v2
branch
from
0f924f8 to
f64e2c2
Compare
t20100
approved these changes
Sep 19, 2025
Member
t20100
left a comment
t20100
left a comment
There was a problem hiding this comment.
Sounds clearer to me with _ColormapPercentileWidget!
I left a few comments, the main one being to avoid emitting percentilesChanged when the value has not changed.
Otherwise LGTM!
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
…tionValue' to '_getSaturation' and '_setSaturation' # Conflicts: # src/silx/gui/dialog/_ColormapPercentileWidget.py
…ase '_DEFAULT_PERCENTILES' evolves with time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
#4371 to be merged first.
Feedback
Still not a big fan of the integration in the dialog. I don't think users can see the link between percentile and saturation.
I might also hide the slider until we are not on the 'percentile' mode.
Demo
output.webm