Skip to content

Simple re-naming of the function to avoid the collision with zlib #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2017
Merged

Simple re-naming of the function to avoid the collision with zlib #654

merged 3 commits into from
Aug 28, 2017

Conversation

kif
Copy link
Member

@kif kif commented Aug 23, 2017

problem with cp27mu in manylinux1

close #649

@vallsv
Copy link
Collaborator

vallsv commented Aug 24, 2017

Would it be possible to rename it pyfai_crc32? instead of my_crc32? I think it would be cleaner.

@kif
Copy link
Member Author

kif commented Aug 25, 2017

why not

@kif kif requested a review from vallsv August 25, 2017 13:51
@kif kif added the ready to merge Please review label Aug 25, 2017
@vallsv vallsv merged commit 20c356a into silx-kit:master Aug 28, 2017
@vallsv
Copy link
Collaborator

vallsv commented Aug 28, 2017

LGTM

@kif kif deleted the 649_libz_collision branch March 15, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vallsv vallsv Awaiting requested review from vallsv

Assignees
No one assigned
Labels
ready to merge Please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault with libz
2 participants
@kif @vallsv