Optimize ndarray uses in MappedVis #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
force-pushed
the
opti-array-reloaded
branch
from
24fbbf0 to
6de5536
Compare
loichuder
force-pushed
the
opti-array-reloaded
branch
from
6de5536 to
ca157b6
Compare
axelboc
approved these changes
Sep 16, 2020
Contributor
axelboc
left a comment
axelboc
left a comment
There was a problem hiding this comment.
Very well found indeed 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revised version of #178 to fix #170.
The
useMemonow lives inMappedVisthat replacedVisProvider. But it was done.Done with
ndarray-ops(scijs/ndarray#32 (comment))Other tasks were not considered as they depend on
cwisewhich does not seem actively maintained as I pointed out.