Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pwa.html #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update pwa.html #40

wants to merge 2 commits into from

Conversation

blackelbow
Copy link

Include crossorigin to prevent 401 when pwa is behind sign in

Added crossorigin to prevent 401
@Archmonger
Copy link

Hey @silviolleite , I'd like to see this PR reviewed & merged. Without this, django-pwa is not usable in any reverse proxy or auth scenario.

Code changes are only one line.

@silviolleite
Copy link
Owner

Hey @silviolleite , I'd like to see this PR reviewed & merged. Without this, django-pwa is not usable in any reverse proxy or auth scenario.

Code changes are only one line.

Thx @Archmonger
Please, you need to fix the unit tests.

@Archmonger
Copy link

Archmonger commented Mar 31, 2021

@silviolleite I am not the author for this PR, and the original author appears to be inactive on GH.

The fix for the unit test is quite simple.
Line 25 of test_template_tags.py needs to be changed.
Previously was: '<link rel="manifest" href="/manifest.json">',
Needs to be '<link rel="manifest" href="/manifest.json" crossorigin="use-credentials">',

Tests will pass after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants