ENH Add generic types #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/3/add-generics
branch
from
ec9da3d
to
d2f7171
Compare
emteknetnz
requested changes
Jan 23, 2024
| @@ -17,6 +17,9 @@ | |||
| * Class TaxonomyDirectoryController | |||
| * | |||
| * Controller for returning a list of pages tagged with a specific Taxonomy Term | |||
| * | |||
| * @template T | |||
There was a problem hiding this comment.
Do we need @template T here? Seems like we're not using it
There was a problem hiding this comment.
Oops nope. Removed it.
I think I was originally adding it because this is a page controller - but then noticed that this controller isn't meant to be subclassed so didn't use it (and forgot to remove it)
GuySartorelli
force-pushed
the
pulls/3/add-generics
branch
from
d2f7171
to
987a071
Compare
emteknetnz
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 and the corresponding silverstripe/cms PR for these generics to take effect.
Issue