Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text alignment class names #59

Merged
merged 1 commit into from
Nov 11, 2018
Merged

Update text alignment class names #59

merged 1 commit into from
Nov 11, 2018

Conversation

lukereative
Copy link

@lukereative lukereative commented Nov 4, 2018 •
edited by dnsl48
Loading

@dnsl48 dnsl48 mentioned this pull request Nov 4, 2018
Open
1 task
dnsl48
dnsl48 suggested changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@dnsl48 dnsl48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wysiwyg button "CENTER" is still stays always pressed. Also, only right and left alignment worked, but couldn't center the caption text anymore.

@dnsl48
Copy link
Contributor

dnsl48 commented Nov 5, 2018

It might be partially, but not completely fixing the issue silverstripe/silverstripe-framework#8520 is that correct?

@dnsl48 dnsl48 mentioned this pull request Nov 11, 2018
Closed
1 task
@dnsl48 dnsl48 merged commit ca2e630 into silverstripe:master Nov 11, 2018
@dnsl48 dnsl48 deleted the pulls/3.2/in-the-box-to-the-left branch November 11, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsl48 dnsl48 dnsl48 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukereative @dnsl48