Revert "FIX Remove $MetaTitle" #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damian ran me through a scenario where this makes sense: It adds a bit of mental overhead to the template, but makes us more flexible in module default behaviour - worth the tradeoff. |
|
I think this will be more apparent once we utilise this in other modules. :) thanks @chillu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #31
Reasoning is that MetaTitle is still a useful function in user code, and doesn't necessarily rely on there being an actual database field for this feature.
Examples of cases this could be useful is where a specific page could customise the meta-title based on the current page action or parameter.