Skip to content

Commit

Permalink
Merge pull request #70 from creative-commoners/pulls/3.0/remove-todo
Browse files Browse the repository at this point in the history
MNT Remove TODO comments
  • Loading branch information
GuySartorelli authored Oct 24, 2023
2 parents de1a170 + c1e66e8 commit 97c4521
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/Forms/GridFieldExportReportButton.php
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ public function generateExportFileData($gridField)
// The is the only variation from the parent, using getList() instead of getManipulatedList()
$items = $gridField->getList();

// @todo should GridFieldComponents change behaviour based on whether others are available in the config?
foreach ($gridField->getConfig()->getComponents() as $component) {
if ($component instanceof GridFieldFilterHeader || $component instanceof GridFieldSortableHeader) {
$items = $component->getManipulatedData($gridField, $items);
Expand Down
1 change: 0 additions & 1 deletion tests/php/UserSecurityReportTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ class UserSecurityReportTest extends SapphireTest
* Utility method for all tests to use.
*
* @return ArrayList
* @todo pre-fill the report with fixture-defined users
*/
protected function setUp(): void
{
Expand Down

0 comments on commit 97c4521

Please sign in to comment.