FIX Handle __TRAIT__ in i18nTextCollector #11137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Since this is a cherry-pick of work that has already been reviewed I'm not going to be too strict, but in the future please fill out the full PR template instead of just removing it. It makes it a lot easier to know what state PRs are in and how much work it might be to review them.
Looks good, will merge on green.
|
Thanks @GuySartorelli. I'll use the template next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies fix committed to v5 to v4.13. Addresses issue identified in tractorcow-farm/silverstripe-fluent#823 and tractorcow-farm/silverstripe-fluent#824
Original PR: #10813
Attn: @GuySartorelli