Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Throw exception when no react component #11059

Merged

Conversation

emteknetnz
Copy link
Member

Issue #11058

Autoscaffolded many_many fields inside of LinkField's will not render because there is no react component for a GridField

This exception gives the develop feedback to remove the field

@emteknetnz emteknetnz force-pushed the pulls/5/schema-exception branch 2 times, most recently from 7602906 to aca9019 Compare November 21, 2023 06:19
src/Forms/Schema/FormSchema.php Outdated Show resolved Hide resolved
src/Forms/Schema/FormSchema.php Outdated Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works well locally.

@GuySartorelli
Copy link
Member

mariadb failure is unrelated

@GuySartorelli GuySartorelli merged commit 26c8c0f into silverstripe:5 Nov 22, 2023
14 of 15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/schema-exception branch November 22, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants