Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Hoverbar ID made uniq #969

Merged
merged 6 commits into from
Apr 13, 2022
Merged

FIX Hoverbar ID made uniq #969

merged 6 commits into from
Apr 13, 2022

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Apr 5, 2022 •
edited
Loading

Parent issue

Description

Make HoverBarComponent attribute ID uniq by adding Elemental Area ID as prefix.
Add tests for ID HoverBarComponent.
Update Behat tests.

@sabina-talipova sabina-talipova mentioned this pull request Apr 10, 2022
Closed
2 tasks
maxime-rainville
maxime-rainville approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on firefox and chrome. Works great. Just made a tiny tweak.

MOG

@maxime-rainville
Copy link
Contributor

Behat failure is pre-existing. We have a separate card to handle this.

@maxime-rainville maxime-rainville merged commit e2b8f18 into silverstripe:4.8 Apr 13, 2022
@maxime-rainville maxime-rainville deleted the pulls/4.8/bugfix-hoverbar-multiple-elementalarea branch April 13, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @maxime-rainville