Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Use new typeMapping graphql API #955

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

unclecheese
Copy link

Resolves #954

@unclecheese
Copy link
Author

unclecheese commented Jan 20, 2022

Merging ahead of green, because it is interdependent with this graphql fix and these tests can't possibly pass without a merge of one or the other

@unclecheese unclecheese merged commit bff0507 into silverstripe:4 Jan 20, 2022
@unclecheese unclecheese deleted the pulls/4/type-mapping branch January 20, 2022 09:33
@emteknetnz
Copy link
Member

@unclecheese please don't self merge unapproved pull-requests on stable branches. I'm less concerned about graphql4's master branch as it's non-stable, however elemental 4 is stable. The build for this PR ended up red and probably would not have been merged in its current state

@unclecheese
Copy link
Author

That was exactly the issue, though. The build couldn't have possibly been green, because it needed that GraphQL PR merged. Now that elemental is in the GraphQL build matrix, these two PRs were interdependent, and something had to merge on red to unlock that paradox.

@emteknetnz
Copy link
Member

emteknetnz commented Jan 20, 2022

I suppose its an unfortunate side-effect that the elemental 4 _graphql folder is effectively at a non-stable level despite it being within stable branch

@unclecheese
Copy link
Author

Well the folder itself is basically inert. It's explicitly including graphql 4.x-dev in the build matrix that makes this stable module dependent on an unstable module, and I think that's a fairly new thing. But interdependent PRs, infrequent as they may be, are just unavoidable in our setup as far as I can tell.

menno-rdmkr pushed a commit to busting-bytes/silverstripe-elemental that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline actions broken in GraphQL4
2 participants