Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Do not publish dataobject in requireDefaultRecords() #1162

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Apr 3, 2024

Issue #1130

As far as I can tell there's absolutely no reason to publish the Page/DataObject at this point. I think the intention was originally to ensure that any owned ElementalAreas would be published ... however they'll just get published when you publish the page/dataobject

I even tested the following succesfully:

  • Remove the elemental extension, dev/build flush
  • Create a blocks page, publish
  • Edit page content, save without publish
  • Enable elemental extension, dev/build flush
  • Create an elemental and inline publish it (note this will mistakenly indicate the page publish button has published, however refreshing the page will show the correct state i.e. page is modified)

There are no network or console warnings when doing this, database records have the correct IDs etc

@emteknetnz emteknetnz changed the base branch from 5 to 4.11 April 3, 2024 05:00
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit efad682 into silverstripe:4.11 Apr 4, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4.11/no-publish branch April 4, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants