Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bits in the readme #1101

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Fix some bits in the readme #1101

merged 2 commits into from
Sep 22, 2023

Conversation

edwilde
Copy link
Contributor

@edwilde edwilde commented Sep 19, 2023 •
edited
Loading

...and it isn't even hacktoberfest yet 😁

  • Fixed the duplicate on line 34 which was breaking the code block
  • Upgraded the **Note** syntax with the proper Github alert syntax

@edwilde
Fix some bits in the readme
215fadf 
...and it isn't even hacktoberfest yet
GuySartorelli
GuySartorelli requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this. Just a small change requested below.

README.md Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks! I'll merge on green

@GuySartorelli GuySartorelli merged commit 76004c3 into silverstripe:5 Sep 22, 2023
12 checks passed
@edwilde edwilde deleted the patch-1 branch September 26, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwilde @GuySartorelli