Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Apply TopPage extensions by default. #1010

Conversation

GuySartorelli
Copy link
Member

@sabina-talipova
Copy link
Contributor

PR closed since it's no longer acceptable.

@GuySartorelli GuySartorelli deleted the pulls/5/apply-extensions-by-default branch November 10, 2022 21:11
@sabina-talipova sabina-talipova restored the pulls/5/apply-extensions-by-default branch November 14, 2022 02:33
@sabina-talipova sabina-talipova force-pushed the pulls/5/apply-extensions-by-default branch 2 times, most recently from 9b79c84 to b09c24c Compare November 14, 2022 02:59
@sabina-talipova
Copy link
Contributor

Reopen PR after discussion with @emteknetnz.

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have tested locally

@sabina-talipova sabina-talipova force-pushed the pulls/5/apply-extensions-by-default branch from b09c24c to 7db1c03 Compare November 15, 2022 01:59
@emteknetnz emteknetnz merged commit 9f0df28 into silverstripe:5 Nov 21, 2022
@emteknetnz emteknetnz deleted the pulls/5/apply-extensions-by-default branch November 21, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants