Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier findability of the functionality to add blocks between other blocks #704

Closed
1 task done
clarkepaul opened this issue Jul 29, 2019 · 5 comments
Closed
1 task done

Comments

@clarkepaul
Copy link

clarkepaul commented Jul 29, 2019

We've had feedback that the initial functionality of adding blocks between other blocks is hard to discover but really loved. @newleeland has created some recommendations for how this can be improved here, approach still to be decided.

Two interactive prototypes to illustrate this
https://codepen.io/newleeland/pen/ormVYx

Prototype 1: Line design.

  • Bigger cursor hitbox
  • Smaller hover delay
  • High contrast line

Prototype 2:

  • Add block buttons always on
  • However, can be less obvious this is adding a block

Implementation

  • We're going for option 1

Pull request

@newleeland
Copy link

@maxime-rainville just FYI
The key part of OPTION 1, isn't so much moving the plus to the middle. but the shorter delay time the removal of the grey line in favour of the the high contrast blue line on hover.

@maxime-rainville
Copy link
Contributor

I'm ditching the time out all together and replacing it with a CSS delay instead.

That will make the component simpler and allow us to remove a bunch silly timeout logic.

@ScopeyNZ
Copy link
Contributor

Yeah the CSS delay wasn't possible with the original implementation because there were instances where certain mouse movements would cause it to show immediately rather than after a delay.

@maxime-rainville
Copy link
Contributor

The delay is currently at 200ms, which is already pretty small to begin with. The card calls for reducing even smaller.

I think in this context it's probably worth using CSS only and having it show immediately in some instance.

This is what it looks like so far https://www.youtube.com/watch?v=qIgJk0JAfrU

@robbieaverill
Copy link
Contributor

Nice @maxime-rainville

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants