Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure inline adding of blocks can be tabbed to #627

Closed
1 task done
brynwhyman opened this issue Mar 8, 2019 · 5 comments
Closed
1 task done

Ensure inline adding of blocks can be tabbed to #627

brynwhyman opened this issue Mar 8, 2019 · 5 comments

Comments

@brynwhyman
Copy link

brynwhyman commented Mar 8, 2019

Overview

It is currently not possible to tab to the function to add blocks inline. This is important as the current drag and drop library doesn't allow for reordering with keyboard actions.

Feature in discussion:
image

Split from #455 so this gets more visibility.

Acceptance Criteria

  • A user is able to add new blocks inline, with keyboard actions

Note

Pull requests

@clarkepaul
Copy link

My recommendation here is to show the add block action before and after each block if a block is hovered (maybe in the middle of the block rather than on the far right?). This means the user doesn't need to hover between the blocks to see the actions. We can also improve the look and feel of the transition (remove the light grey in-between faded look). A design will be required prior to this one being implemented.

@brynwhyman
Copy link
Author

Before looking at this issue, we plan to investigate #455

@newleeland
Copy link

My recommendation here is to show the add block action before and after each block if a block is hovered (maybe in the middle of the block rather than on the far right?). This means the user doesn't need to hover between the blocks to see the actions. We can also improve the look and feel of the transition (remove the light grey in-between faded look). A design will be required prior to this one being implemented.

I've made two interactive prototypes to illustrate this
https://codepen.io/newleeland/pen/ormVYx

Prototype 1: Line design.

  • Bigger cursor hitbox
  • Smaller hover delay
  • High contrast line

Prototype 2:

  • Add block buttons always on
  • However, can be less obvious this is adding a block

@clarkepaul
Copy link

I think we should probably separate the design improvements to the tabbing issue. Opened a different issue to cover them here #704

@robbieaverill
Copy link
Contributor

Nice @maxime-rainville

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants